Implement support for headstage-64 firmware 0.4 #520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove explcity ostim and estim trigger delay registers in favor of dynamic delay via trigger register - Add the ability to turn off indication LED - Fix register values and frame defintions - Add persistant heartbeat device to Headstage64 device aggregate
bparks13
reviewed
Oct 14, 2025
Member
bparks13
left a comment
bparks13
left a comment
There was a problem hiding this comment.
Overall I have a couple questions that might need to be addressed, see my comments.
I also added the heartbeat tab to the HS64 dialog; this would not be necessary if #517 was implemented, but for now it is needed to see the device added.
Member
Author
|
This is superseded by #529. I will address all these comments in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.